Silver 1.5.4

[noobsoftware]

Following the latest UXP release and Basilisk update, here is Silver 1.5.4

For those who don't know Silver is Basilisk for macOS

Download link:

https://noob.software/downloads/silver-v1.5.4.dmg

sources:

UXP source: https://repo.palemoon.org/dbsoft/UXP/

Basilisk source: https://repo.palemoon.org/Basilisk-Dev/Basilisk

Silver source: https://github.com/noobsoftware/silver2

[dbsoft]

Following the latest UXP release and Basilisk update, here is Silver 1.5.4

Awesome! Thanks!

Guess you didn't try out WebRTC with the latest changes?

[noobsoftware]

Following the latest UXP release and Basilisk update, here is Silver 1.5.4

Awesome! Thanks!

Guess you didn't try out WebRTC with the latest changes?

I tried it out but it didn't work, according to basilisk-dev it should work, as it works on Windows on Linux. Here is the error i got:

1:07.47 nsCSSPropsGenerated.inc
1:07.47 xpcAccEvents.h
1:07.60 /Users/siggi/Documents/silver_build3/basilisk/platform/dom/webidl/CSS2Properties.webidl.in
1:09.59 Traceback (most recent call last):
1:09.59  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 174, in _run_module_as_main
1:09.59    "__main__", fname, loader, pkg_name)
1:09.59  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
1:09.59    exec code in run_globals
1:09.59  File "/Users/siggi/Documents/silver_build3/basilisk/platform/python/mozbuild/mozbuild/action/webidl.py", line 19, in <module>
1:09.59    sys.exit(main(sys.argv[1:]))
1:09.59  File "/Users/siggi/Documents/silver_build3/basilisk/platform/python/mozbuild/mozbuild/action/webidl.py", line 15, in main
1:09.59    manager.generate_build_files()
1:09.59  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/mozwebidlcodegen/__init__.py", line 249, in generate_build_files
1:09.59    self._parse_webidl()
1:09.59  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/mozwebidlcodegen/__init__.py", line 336, in _parse_webidl
1:09.59    parser.parse(data, path)
1:09.59  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 6807, in parse
1:09.59    self._productions.extend(self.parser.parse(lexer=self.lexer, tracking=True))
1:09.59  File "/Users/siggi/Documents/silver_build3/basilisk/platform/other-licenses/ply/ply/yacc.py", line 263, in parse
1:09.60    return self.parseopt(input,lexer,debug,tracking,tokenfunc)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/other-licenses/ply/ply/yacc.py", line 710, in parseopt
1:09.60    p.callable(pslice)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 5683, in p_CallbackRest
1:09.60    identifier, p[3], p[5])
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 4430, in __init__
1:09.60    IDLObjectWithScope.__init__(self, location, parentScope, identifier)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 459, in __init__
1:09.60    IDLObjectWithIdentifier.__init__(self, location, parentScope, identifier)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 410, in __init__
1:09.60    self.resolve(parentScope)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 417, in resolve
1:09.60    self.identifier.resolve(parentScope, self)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 390, in resolve
1:09.60    scope.ensureUnique(self, object)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 274, in ensureUnique
1:09.60    object)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 316, in resolveIdentifierConflict
1:09.60    newObject.location)
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 248, in __str__
1:09.60    return self.QName()
1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 251, in QName
1:09.60    if self._name:
1:09.60 AttributeError: 'IDLCallback' object has no attribute '_name'
1:09.64 make[5]: *** [codegen.pp] Error 1
1:09.64 make[4]: *** [dom/bindings/export] Error 2
1:09.64 make[4]: *** Waiting for unfinished jobs....
1:16.16 make[3]: *** [export] Error 2
1:16.16 make[2]: *** [default] Error 2
1:16.16 make[1]: *** [realbuild] Error 2
1:16.16 make: *** [build] Error 2
1:16.20 0 compiler warnings present.

It fails almost immediately in the start of the build, i think i pasted all the relevant lines from the build output.

[dbsoft]

Following the latest UXP release and Basilisk update, here is Silver 1.5.4

Awesome! Thanks!

Guess you didn't try out WebRTC with the latest changes?

I tried it out but it didn't work, according to basilisk-dev it should work, as it works on Windows on Linux. Here is the error i got:

1:09.60  File "/Users/siggi/Documents/silver_build3/basilisk/platform/dom/bindings/parser/WebIDL.py", line 251, in QName
1:09.60    if self._name:
1:09.60 AttributeError: 'IDLCallback' object has no attribute '_name'

It fails almost immediately in the start of the build, i think i pasted all the relevant lines from the build output.

Interesting, that isn't even failing in the build, it is one of the python scripts to generate the IDL.... I am busy this weekend but next week I'll try to build it myself using your repo and see what happens.

[noobsoftware]

Great.

[dbsoft]

UXP source: https://repo.palemoon.org/dbsoft/UXP/

Can I verify you are not using this repository and are using Moonchild's https://repo.palemoon.org/MoonchildProductions/UXP ?

I just started a build and it proceeded past the point yours errored out.  So either you are using the wrong UXP or there is something not quite right with your build environment.

[dbsoft]

The build completed successfully with no changes to anything:

Code:

git clone https://github.com/noobsoftware/silver2 ./Silver
cd Silver
git clone https://repo.palemoon.org/MoonchildProductions/UXP ./platform
(create .mozconfig below)
./mach build
./mach package

Code:

# Standard build options for Silver
ac_add_options --enable-application=basilisk
ac_add_options --enable-optimize="-O3"
ac_add_options --enable-jemalloc
ac_add_options --enable-strip
ac_add_options --enable-devtools
ac_add_options --enable-av1
ac_add_options --enable-eme
ac_add_options --enable-webrtc
ac_add_options --enable-gamepad
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-necko-wifi
ac_add_options --disable-updater
ac_add_options --with-macos-sdk=/Users/nuke/SDKs/MacOSX10.12.sdk
ac_add_options --with-branding=basilisk/branding/unofficial

# Uncomment if using clang++ from Xcode 10 or higher
export CXX="/usr/bin/clang++ -std=gnu++11 -stdlib=libc++"

Download Silver WebRTC Intel Build SHA256: d4d430929093f5d7856083eb13a409fd404ddf76c7cd8baf10e07fc24410c91a

Code:

# Standard build options for Silver
ac_add_options --enable-application=basilisk
ac_add_options --enable-optimize="-O3"
ac_add_options --enable-jemalloc
ac_add_options --enable-strip
ac_add_options --enable-devtools
ac_add_options --enable-av1
ac_add_options --enable-eme
ac_add_options --enable-webrtc
ac_add_options --enable-gamepad
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-necko-wifi
ac_add_options --disable-updater
ac_add_options --host=aarch64-apple-darwin
ac_add_options --target=aarch64-apple-darwin
ac_add_options --with-macos-sdk=/Users/lucy/SDKs/MacOSX11.3.sdk
ac_add_options --with-branding=basilisk/branding/unofficial

# Uncomment if using clang++ from Xcode 10 or higher
export CXX="/usr/bin/clang++ -std=gnu++11 -stdlib=libc++"

Download Silver WebRTC Apple Silicon (ARM64) Build SHA256: e935a8a14480025ac149714b25cc51b96988806611024959bfae5c59117feccd

[noobsoftware]

Incredible! Looks great, i don't know what i was doing wrong. Thanks for posting the builds as well. I will use the config you posted here for my next build.

---

If you are interested in building Silver, or have the time to do it, it would be fine with me, since you can ensure proper builds as well as building for apple silicon. If not i will continue to do the Intel builds, I have updated my apple silicon mac to Venture pre-release so i can not make apple silicon builds until the build environment is available and you have made it possible in UXP.

[dbsoft]

If you are interested in building Silver, or have the time to do it, it would be fine with me, since you can ensure proper builds as well as building for apple silicon. If not i will continue to do the Intel builds, I have updated my apple silicon mac to Venture pre-release so i can not make apple silicon builds until the build environment is available and you have made it possible in UXP.

Well, doing Silver builds would double the time but... that probably isn't a big deal.

Do you change anything besides the branding? If not... could you just make a branding repository?  Then I'll just use the basilisk repository/UXP and your branding repository to do the builds.

[noobsoftware]

If you are interested in building Silver, or have the time to do it, it would be fine with me, since you can ensure proper builds as well as building for apple silicon. If not i will continue to do the Intel builds, I have updated my apple silicon mac to Venture pre-release so i can not make apple silicon builds until the build environment is available and you have made it possible in UXP.

Well, doing Silver builds would double the time but... that probably isn't a big deal.

Do you change anything besides the branding? If not... could you just make a branding repository?  Then I'll just use the basilisk repository/UXP and your branding repository to do the builds.

Here are all of the modified files:

/Volumes/siggi/Desktop/silver/basilisk/basilisk/branding/unofficial
/Volumes/siggi/Desktop/silver/basilisk/basilisk/themes/osx/browser.css
/Volumes/siggi/Desktop/silver/basilisk/basilisk/base/content/browser.css
/Volumes/siggi/Desktop/silver/basilisk/basilisk/base/content/tabbrowser.css
/Volumes/siggi/Desktop/silver/basilisk/basilisk/base/content/aboutDialog.xul
/Users/siggi/Desktop/silver/basilisk/basilisk/app/macbuild/Contents/Info.plist.in

I had to modify the XUL to modify the theme. I can possibly release the original theme as a custom theme as well.

It would be awesome if you could handle it. Also if there is a possibility for automatic updates any time in the future it would be cool if you could handle both releases. I will continue to host a copy of your release of Silver on my server to spread the server load.