(03-18-2022, 07:35 PM)noobsoftware Wrote: I expected that change to happen, since WebRTC is very complex and not even the major browsers are very consistent with their versions of WebRTC. I have been using WebRTC in Silver, but if it is much trouble to maintain it i can of course build with it disabled. But it would be more promising to try to update it. Although that is far beyond my area of expertise.
Btw it seems that the mp3 issue was not fixed in my build of Silver 1.4.6, it seems to have only worked on the clang branch when built using the latest version of macOS and latest Xcode. I wonder if the same applies for white star, in which case, i hope the clang branch pans out and ends up working since mp3 playback is somewhat important.
So, I am still getting a crash with -O3 even with the new changes, it is in a different location, which has me fairly confused... the debugger can't see the variable at issue. I am still investigating, might see if it is a memory corruption problem with optimizations, might try to turn on the stack protector.
However, I am curious if you build with the latest changes if you still experience the MP3 playback issue.
I think I want to incorporate these changes into the tree though, they are much cleaner and allow thread protection for the members of the classes. I am currently debating merging them to master now, just a little concerned because there were so many changes and I've only been testing for a few days now... although I have not noticed any issue on Mac, Windows or Linux since I committed Part 4.
Also in response to a comment in the other thread, I intend to keep my UXP so you can continue to build Silver, which is why I wanted to know if you needed WebRTC in Silver... that would affect my decision on what changes to merge over from Pale Moon.